[PATCH] D103230: [AMDGPU] Disable NSA for BVH instructions when appropriate

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 2 02:06:14 PDT 2021


foad added a comment.

LGTM, thanks!



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:7421
+        SDValue Undef = DAG.getUNDEF(MVT::i32);
+        while (Ops.size() < 16)
+          Ops.push_back(Undef);
----------------
Nit: I think you can do `Ops.append(16 - Ops.size(), Undef)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103230/new/

https://reviews.llvm.org/D103230



More information about the llvm-commits mailing list