[PATCH] D102834: [SLPVectorizer] Implement initial memory versioning.

Mon Aug 2 00:57:08 PDT 2021

SjoerdMeijer added a comment.

In D102834#2914099 <https://reviews.llvm.org/D102834#2914099>, @fhahn wrote:

> In D102834#2866603 <https://reviews.llvm.org/D102834#2866603>, @SjoerdMeijer wrote:
>
>> Just a bit of a heads up that I took this patch (and it's dependencies) and run some numbers for x264 SPEC, where I have seen quite a few missed opportunities caused by inability to emit runtime alias checks. I don't see any change in performance though, which is slightly unexpected (I was hoping for some already). But it might be that the next thing is blocking SLP vectorisation, for AArch64 which is what I am looking at, and that might be cost-model issues. This is the case for the 2 examples I am currently looking at, but will do some more analysis. And we of course need this patch as an enabler.
>
> The case from x264 is in the function `@f_alias` in `../AArch64/loadi8.ll`, right?

Sorry for the late reply, but just wanted to confirm this: yes, that `@f_alias` in `../AArch64/loadi8.ll` is a reproducer from x264.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102834/new/

https://reviews.llvm.org/D102834