[PATCH] D45962: [MC] Use local MCSubtargetInfo in writeNops

Thu Jul 29 14:53:45 PDT 2021

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
Herald added subscribers: frasercrmck, kerbowa, luismarques, sameer.abuasal, pengfei, s.egerton, Jim, MaskRay, jrtc27.

LGTM, assuming it rebases cleanly

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.h:22
 class ARMAsmBackend : public MCAsmBackend {
-  // The STI from the target triple the MCAsmBackend was instantiated with
-  // note that MCFragments may have a different local STI that should be
-  // used in preference.
-  const MCSubtargetInfo &STI;
   bool isThumbMode;    // Currently emitting Thumb code.
 public:
----------------
isThumbMode should probably be using the ThumbMode bit of MCSubtargetInfo... but I'm not sure we're actually updating that at the moment. Probably okay to leave it for a followup.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45962/new/

https://reviews.llvm.org/D45962