[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

Alf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 28 10:08:16 PDT 2021


gAlfonso-bit added a comment.

In D106899#2910655 <https://reviews.llvm.org/D106899#2910655>, @MaskRay wrote:

> I migrated all llvm/ files. You need to remove them from the patch.
>
> It is a good idea to drop the macro definition in `llvm/include/llvm/Support/Compiler.h` separately.
>
> It makes it easy to bring back the definition if some important downstream users want extended time for migration.
> (Note: the policy is that downstream is on their own. Our thinking of this is kindness, not an obligation of llvm-project.)
> For example, swift is using `LLVM_ATTRIBUTE_NORETURN`.
> (I researched a bit: `LLVM_ATTRIBUTE_NORETURN` is not common in downstream projects.)

Alright, but can we cherry pick this to release when this is all said and done?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106899/new/

https://reviews.llvm.org/D106899



More information about the llvm-commits mailing list