[PATCH] D107237: [LLD][MinGW] Accept joined format for --stack

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 1 13:08:11 PDT 2021


mstorsjo added a comment.

In D107237#2918830 <https://reviews.llvm.org/D107237#2918830>, @jeremyd2019 wrote:

> In D107237#2918766 <https://reviews.llvm.org/D107237#2918766>, @mati865 wrote:
>
>>> From a quick look at the options listing, I presume most other cases of S<> and J<…=> should be changed into Eq<> too.
>>
>> It's very likely but I don't know how to easily check it with BFD and I think this was the only problematic flag recently.
>
> lld: error: unknown argument: --image-base=0x10000000 ?

Yes, that shows that lld doesn't support that form of that option - the question is whether ld.bfd supports that form of that particular option (I would assume it does as it uses getopt iirc).

Other than those two, there's also `--major-image-version`/`--minor-image-version` (which lld currently just ignores), and `-mllvm` (which only has correspondence in the lld ELF backend, where it supports both option forms), and `--icf` (which only is supported in the `--icf=<foo>` form currently. Additionally the option definitions of `plugin` and `plugin-opt` could be simplified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107237/new/

https://reviews.llvm.org/D107237



More information about the llvm-commits mailing list