[PATCH] D107180: [InstCombine] Prevent unnecessary sinks caused by the Freeze

Hyeongyu Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 31 10:01:18 PDT 2021


hyeongyukim abandoned this revision.
hyeongyukim added a comment.

In D107180#2917128 <https://reviews.llvm.org/D107180#2917128>, @lebedev.ri wrote:

> Yeah, i think there's already a profitability check there, so i don't see why we'd want this.
> It could be interesting to enhance the sinking to handle multiple uses (see `findCommonDominator()` in `SimplifyIndVar.cpp`),
> not sure what compile-time implications that would have.

I am writing a new patch(D107226 <https://reviews.llvm.org/D107226>) related to your comment.
I agree that this patch is not profitable, so I'll close it!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107180/new/

https://reviews.llvm.org/D107180



More information about the llvm-commits mailing list