[PATCH] D107187: [amdgpu] Add an enhanced conversion from i64 to f32.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:2118-2119
+  auto Scale = B.buildSub(S32, B.buildConstant(S32, 32), ShAmt);
+  SmallVector<Register, 1> Results;
+  Results.push_back(Dst);
+  B.buildIntrinsic(Intrinsic::amdgcn_ldexp, Results, /*HasSideEffects=*/false)
----------------
hliao wrote:
> hliao wrote:
> > arsenm wrote:
> > > You can just do {Dst} directly to the buildInstr call
> > I remembered I tried that but still cannot compile it. Let me try again
> Still cannot compile. I noticed that 'buildIntrinsic' has two prototypes. {Dst} make that ambiguous for the compiler to choose.
This ambiguity isn't great. Using ArrayRef<Register>{Dst} works


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107187/new/

https://reviews.llvm.org/D107187