[PATCH] D107219: [LICM] Support sinking in LNICM

[toshiki maekawa via Phabricator via llvm-commits]

uint256_t added inline comments.


================
Comment at: llvm/test/Transforms/LICM/lnicm-sink.ll:11
+;   for (int i = 0; i < 10; i++) {
+;     for (int j = 0; j < 10; j++) {
+;       t = sin(x);
----------------
xbolva00 wrote:
> j not used? It would be better to use more “realistic” example.
I don't think `j` need to be used. This test shows how LNICM handles a loop nest when it does sinking.  If we use `j` here, an instruction using it would be neither hoisted or sunk, so I think it is redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107219/new/

https://reviews.llvm.org/D107219