[PATCH] D107216: Revert [MC][ELF] Emit separate unique sections for different flags

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 31 01:22:51 PDT 2021


MaskRay added a comment.

> This functionality is used by rustc to embed LTO bitcode with the SHF_EXCLUDE flag, and currently blocks our evaluation of the LLVM 13 release.

But Rust usage is technically incorrect. I think Rust can carry its own patch to for the LLVM 13 release.

> As the post-commit discussion on D100944 <https://reviews.llvm.org/D100944> indicates, other people were using this functionality as well: https://reviews.llvm.org/D100944#2840948

I think @bd1976llvm have found a way forward.

This cannot be used as an argument favoring the revert: the code abuses a property which cannot be guaranteed by the assembler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107216/new/

https://reviews.llvm.org/D107216



More information about the llvm-commits mailing list