[PATCH] D107116: [ConstantFold] Get rid of special cases for sizeof etc.

Sat Jul 31 00:59:19 PDT 2021

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM -- the target-dependent folder is going to reduce these to constants, I don't see any value in trying very hard to optimize them in the target-indepenedent folder.

Note that you need to adjust clang codegen tests as well.

================
Comment at: llvm/test/Other/constant-fold-gep.ll:50
 ; simplifications on sizeof, alignof, and offsetof expressions. The
 ; target-dependent folder should fold these down to constants.

----------------
Outdated comment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107116/new/

https://reviews.llvm.org/D107116