[PATCH] D106624: [DWARF] Don't process .debug_info relocations for DWO Context

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds good - thanks for your patience!



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h:390
 
+  enum class ProcessDebugRelocations { Process, Ignore };
+
----------------
While I think the new name is more descriptive - it still feels a bit confusing for readers at call sites - still feels like the caller passing "ProcessDebugRelocations::Ignore" would benefit from a comment explaining why they should be ignored here (& maybe even similarly at the other call sites passing "Process" - be nice if it were a defaulted argument, but the other mix of defaulted arguments means it's hard to actually use the default (because other callers want to specify some subset of the arguments)... 

Hmm, but I keep coming up with issues with all the other ideas for naming/API design I have here, so let's just go with this one. It's not used prolifically and could be renamed/improved later without significant cost.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106624/new/

https://reviews.llvm.org/D106624