[PATCH] D107110: [CallSiteInfo][CallGraphSection] Extend CallSiteInfo with TypeId

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Should add some parse failure condition tests



================
Comment at: llvm/lib/CodeGen/MIRParser/MIRParser.cpp:406
     }
+    if (YamlCSInfo.TypeId.hasValue()) {
+      IntegerType *Int64Ty = Type::getInt64Ty(Context);
----------------
Don't need hasValue


================
Comment at: llvm/lib/CodeGen/MIRParser/MIRParser.cpp:408
+      IntegerType *Int64Ty = Type::getInt64Ty(Context);
+      CSInfo.TypeId = ConstantInt::get(Int64Ty, YamlCSInfo.TypeId.getValue(),
+                                       /*isSigned=*/false);
----------------
* instead of getValue


================
Comment at: llvm/test/CodeGen/MIR/X86/call-site-info-typeid.mir:7
+# CHECK: callSites:
+# CHECK-NEXT: - { bb: {{.*}}, offset: {{.*}}, fwdArgRegs: [], typeId:
+# CHECK-NEXT: 123456789 }
----------------
Should check the actual values are preserved


================
Comment at: llvm/test/CodeGen/MIR/X86/call-site-info-typeid.mir:11-32
+  ; ModuleID = 'test.ll'
+  source_filename = "test.ll"
+  target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+  target triple = "x86_64-unknown-linux-gnu"
+  
+  define dso_local void @foo(i8 signext %a) {
+  entry:
----------------
Does this really need the IR section?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107110/new/

https://reviews.llvm.org/D107110