[PATCH] D107192: [llvm-profgen][CSSPGO] Support count based aggregated type of hybrid perf script

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.h:66
+  PERF_LBR_STACK = 3,     // Hybrid sample including call stack and LBR stack.
+  PERF_LBR_STACK_AGG = 4, // Aggregated hybrid sample perf
 };
----------------
How about we make the aggregation form an "extension" applicable to any perf script type instead of a new type? This is because we could have a count for LBR perf script too (when we use llvm-profgen for line-based AutoFDO too in the future). If we make aggregation a separate type, we would potentially need to double the number of types.. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107192/new/

https://reviews.llvm.org/D107192