[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

As far as I can tell, the lastest version of the diff you uploaded still has the following issues that haven't been addressed:

1. The BOM handling is actually actively a problem if you're planning to use the interface to interpret wprintf format strings. We don't want to byteswap `L"\uFFFE%s"` or something like that.
2. `SrcBytes.size() * UNI_MAX_UTF8_BYTES_PER_CODE_POINT + 1` seems like way too much memory.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106753/new/

https://reviews.llvm.org/D106753