[PATCH] D107097: [llvm-profgen] Support perf script without parsing MMap events

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:662
+  if (EventSeenFirst.hasValue() && !EventSeenFirst.getValue()) {
+    WithColor::warning() << "Interior mmap event but no leading mmap event!\n";
+  } else if (!EventSeenFirst.hasValue()) {
----------------
The term "Interior mmap event" could be confusing..  

The warning I was thinking is for when LBR/stack sample is seen before a relevant mmap is seen, in which case we warn about assuming preferred based address due to not seeing corresponding mmap. It doesn't matter whether we found other mmap event later or not. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107097/new/

https://reviews.llvm.org/D107097