[PATCH] D107097: [llvm-profgen] An option to ignore parsing MMap events

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:761
+  for (auto Filename : PerfTraceFilenames) {
+    checkLeadingMmapEvent(Filename);
     parseAndAggregateTrace(Filename);
----------------
hoy wrote:
> Instead of a prescan for leading mmap events based on limited number of lines, can we compute a flag, say `EventSeenFirst`, the value of which can be sample events or mmap events, during `parseAndAggregateTrace` and check it in `parseMMap2Event`? 
Good idea! Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107097/new/

https://reviews.llvm.org/D107097