[PATCH] D107195: [Zorg] Add timputs to OpenMP tests.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 30 14:16:53 PDT 2021


Meinersbur created this revision.
Meinersbur added reviewers: gkistanova, tianshilei1992.
Meinersbur added a project: Zorg.
Herald added subscribers: guansong, yaxunl.
Meinersbur requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

This patch sets an individual test timeout of 10 seconds. Due to bug llvm.org/PR51235 some tests sometimes take 20 minutes to executed. The timeout is meant to reduce the overall build time and allow detection over tests that take abnormal time to execute.

The timeout of 10s was suggested by @tianshilei1992 which current causes 7 tests to fail (See http://meinersbur.de:8011/#/builders/1). I don't know whether all of them are due to llvm.org/PR51235 or whether some regularly take longer than 10 seconds.


Repository:
  rZORG LLVM Github Zorg

https://reviews.llvm.org/D107195

Files:
  buildbot/osuosl/master/config/builders.py
  zorg/buildbot/builders/OpenMPBuilder.py


Index: zorg/buildbot/builders/OpenMPBuilder.py
===================================================================
--- zorg/buildbot/builders/OpenMPBuilder.py
+++ zorg/buildbot/builders/OpenMPBuilder.py
@@ -21,6 +21,7 @@
         testsuite           = False,
         testsuite_sollvevv  = False,
         extraTestsuiteCmakeArgs = [],
+        extraLitArgs        = [],
         **kwargs):
 
     # Prepare environmental variables. Set here all env we want everywhere.
@@ -69,6 +70,7 @@
         cmake_args += ['-DLIBOMP_OMPT_SUPPORT=ON']
     if test:
         lit_args = '-vv --show-unsupported --show-xfail -j %s' % jobs
+        lit_args = ' '.join([lit_args] + extraLitArgs)
         cmake_args += [WithProperties('-DLLVM_LIT_ARGS=%s' % lit_args)]
     if install:
         cmake_args += [WithProperties('-DCMAKE_INSTALL_PREFIX=%(builddir)s/' + llvm_instdir)]
Index: buildbot/osuosl/master/config/builders.py
===================================================================
--- buildbot/osuosl/master/config/builders.py
+++ buildbot/osuosl/master/config/builders.py
@@ -1343,6 +1343,7 @@
                             "-DTEST_SUITE_SOLLVEVV_OFFLOADING_CFLAGS=-fopenmp-targets=nvptx64-nvidia-cuda;--cuda-path=/opt/cuda",
                             "-DTEST_SUITE_SOLLVEVV_OFFLOADING_LDFLAGS=-fopenmp-targets=nvptx64-nvidia-cuda;--cuda-path=/opt/cuda",
                         ],
+                        extraLitArgs=['--timeout=10'],
                     )},
 
     {'name' : "openmp-offload-cuda-runtime",
@@ -1371,6 +1372,7 @@
                             "-DTEST_SUITE_SOLLVEVV_OFFLOADING_CFLAGS=-fopenmp-targets=nvptx64-nvidia-cuda;--cuda-path=/opt/cuda",
                             "-DTEST_SUITE_SOLLVEVV_OFFLOADING_LDFLAGS=-fopenmp-targets=nvptx64-nvidia-cuda;--cuda-path=/opt/cuda",
                         ],
+                        extraLitArgs=['--timeout=10'],
                     )},
 
 # Libc++ builders.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107195.363202.patch
Type: text/x-patch
Size: 1933 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210730/c9ac2b7b/attachment.bin>


More information about the llvm-commits mailing list