[PATCH] D107139: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 30 14:14:44 PDT 2021


craig.topper added inline comments.


================
Comment at: clang/lib/Basic/Targets/RISCV.cpp:108
   case 'v':
-    R = std::string("v");
+    R = std::string("@2") + std::string(Constraint, 2);
     Constraint += 1;
----------------
I believe most targets use `std::string("^") + std::string(Constraint, 2)` for 2 letter constraints

AArch64 added the @ format and uses @3 for a 3 letter constraint. But it didn't get documented in the LangRef.

Can we use the ^ here which is documented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107139/new/

https://reviews.llvm.org/D107139



More information about the llvm-commits mailing list