[PATCH] D107185: [LoopStrengthReduction] Fix pointer to int extend asserts

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:4082
   if (!DstTy) return;
   if (DstTy->isPointerTy())
     return;
----------------
bcahoon wrote:
> efriedma wrote:
> > Should we force Formula::getType() to always return an integer type, to avoid confusion like this in the future?
> I'm not sure that would be correct?
At the moment, Formula::getType() is picking the type of a random part of the formula, basically.  It seems like picking consistently would be an improvement?

(In any case, doesn't need to be part of this patch.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107185/new/

https://reviews.llvm.org/D107185