[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

Steven Wan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 30 12:46:29 PDT 2021


stevewan added inline comments.


================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1783
+    if (FieldPacked) {
+      FieldAlign = UnpackedFieldAlign = 1;
+    } else if (!MaxFieldAlignment.isZero()) {
----------------
`UnpackedFieldAlign` is used to check if the packed attribute is unnecessary (-Wpacked). here the attribute is making a difference, we probably shouldn't set `FieldAlign = UnpackedFieldAlign`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106900/new/

https://reviews.llvm.org/D106900



More information about the llvm-commits mailing list