[PATCH] D106915: Add a DIExpression const-folder to prevent silly expressions

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/unittests/IR/MetadataTest.cpp:2912
+  Expr = DIExpression::get(Context, {dwarf::DW_OP_deref});
+  EXPECT_EXPR_FOLD(32, 117, 32, 117, 1);
+  EXPECT_EQ(NewExpr, Expr);
----------------
Thanks! Assuming these are dwarf expression ops, could spell them out here using the Dwarf.def enums? Or does that mess with the macro? If so, maybe we could at least add a comment expanding the raw numbers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106915/new/

https://reviews.llvm.org/D106915