[PATCH] D107014: [llvm-profgen] Refactor PerfReader to allow different types of perf scripts

[Hongtao Yu via Phabricator via llvm-commits]

hoy accepted this revision.
hoy added a comment.
This revision is now accepted and ready to land.

LGTM, except for a minor naming issue.



================
Comment at: llvm/tools/llvm-profgen/llvm-profgen.cpp:53
+  if (ShowDisassemblyOnly) {
+    PerfReaderBase::loadBinaries(BinaryFilenames);
     return EXIT_SUCCESS;
----------------
Nit: On the second thought, maybe just inlined the function here? `PerfReaderBase` doesn't seem a good resort for this function either since conceptually we want to by pass the perfreader and exit early.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107014/new/

https://reviews.llvm.org/D107014