[PATCH] D107143: [profile] Fix merging with binary IDs
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 30 10:17:08 PDT 2021
phosek added inline comments.
================
Comment at: compiler-rt/include/profile/InstrProfData.inc:649
/* Raw profile format version (start from 1). */
#define INSTR_PROF_RAW_VERSION 6
/* Indexed profile format version (start from 1). */
----------------
hans wrote:
> Does this need to be incremented for the header field move?
I wasn't sure if it's necessary since few projects probably picked up this change so far given that we haven't heard any reports of this issue other than Chromium and the change only landed last week, but I suppose it wouldn't hurt to bump the version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107143/new/
https://reviews.llvm.org/D107143
More information about the llvm-commits
mailing list