[PATCH] D107060: [SPEC2017] Add timeit dependencies to validator and bench binaries.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D107060#2914840 <https://reviews.llvm.org/D107060#2914840>, @fhahn wrote:

> In D107060#2914802 <https://reviews.llvm.org/D107060#2914802>, @Meinersbur wrote:
>
>> If there are no easy answers to my questions, I'd just approve the patch. At worst we have redundant dependencies to `timeit` or build it even with though `TEST_SUITE_COLLECT_COMPILE_TIME=OFF`.
>
> I'm not entirely sure myself. I *think* at least for `  llvm_test_executable(${PROG} ${_sources})` it should not be needed, because the dependencies should be added elsewhere already. Let me try to reproduce the issue again before continuing.

I ran into the build failure again and I think it is just the validator binary that is missing the dependency. The committed version only adds `build-timeit` to the validator binary.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107060/new/

https://reviews.llvm.org/D107060