[PATCH] D107157: [NFC] Clean up tests in test/Transforms/LoopVectorize/assume.ll

[Sanjay Patel via Phabricator via llvm-commits]

spatel added reviewers: lebedev.ri, dmgreen, RKSimon.
spatel added a comment.

I assume (pun...) that I updated this file with the complete checks while making a vectorizer change that may or may not have made it to trunk commit.

With full checks, the process of seeing/making changes is automated and so someone who is not expert at the intent of these tests can easily submit the diffs for review (and someone more knowledgeable can pass judgement). It may create some noise/work for subsequent patches, but it also makes it highly visible when a patch is having an unintended consequence.

So IIUC, this patch is likely to remove this file from some generally unrelated upcoming code change. But if that's the gain, is it worth the cost of making it harder for other, less expert contributors to make changes? Let me know if I got that wrong. I won't block this either way, but hopefully that explains why we currently have the full checks.

If we do remove the full checks, please remove or update the first line in the file, so we're not misleading about the script usage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107157/new/

https://reviews.llvm.org/D107157