[PATCH] D106852: [SCEV] Fix getAddExpr for adding loop invariants into start of some AddRec

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

@efriedma I think that false-positive for `is0thIterationGuaranteed` is fine. It just means that we think that we must go to the 2nd iteration of the outer loop, and therefore we can derive its flag from our conditions. If we don't use the opportunity to go there due to abnormal exit, it's fine.

We only strengthen flags when `is0thIterationGuaranteed` is false. So false-negative would be a problem, but always responding `true` is not a problem at all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106852/new/

https://reviews.llvm.org/D106852