[PATCH] D107062: [flang][nfc] Fix variable names in `FrontendOptions`

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 30 02:49:37 PDT 2021


awarzynski added inline comments.


================
Comment at: flang/include/flang/Frontend/FrontendOptions.h:253
+      : showHelp(false), showVersion(false), instrumentedParse(false),
+        needProvenanceRangeToCharBlockMappings(false) {}
 
----------------
klausler wrote:
> It is confusing to have data member initialization mixed between the constructor and the data member declarations when all of initialization expressions are constants.
I agree that the location of this constructor is unfortunate. Let me move it to the top.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107062/new/

https://reviews.llvm.org/D107062



More information about the llvm-commits mailing list