[PATCH] D107089: [flang][driver] Add print function name Plugin example

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Thank you for working on this @stuartellis ! This plugin is going to be a great reference example for walking the parse tree.

I have a couple of suggestions:

- I think that you can replace `flangHelloWorldPlugin` with `flangPrintFunctionNames`. The former becomes uninteresting when compared to the latter :)
- Could you add more tests? More on this below.

Ideas for extra tests:

- function + subroutine **calls** (these should not be taken into account, right?)
- functions within INTERFACE <https://web.stanford.edu/class/me200c/tutorial_90/08_subprograms.html> s
- external vs internal <https://masuday.github.io/fortran_tutorial/subroutines.html> functions and subroutines

I know that @kiranchandramohan used the visitor API before, so perhaps he'll have another suggestion.



================
Comment at: flang/examples/PrintFlangFunctionNames/CMakeLists.txt:6
+)
\ No newline at end of file

----------------
FIXME


================
Comment at: flang/examples/PrintFlangFunctionNames/PrintFlangFunctionNames.cpp:58
+    "print-fns", "Print Function names");
\ No newline at end of file

----------------
FIXME



================
Comment at: flang/test/Driver/plugin-print-fns.f90:29
+end subroutine routine
\ No newline at end of file

----------------
FIXME


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107089/new/

https://reviews.llvm.org/D107089