[PATCH] D62583: [llvm-objcopy] Implement IHEX reader

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.
Herald added a subscriber: abrachet.


================
Comment at: llvm/trunk/tools/llvm-objcopy/ELF/Object.cpp:1201
+        Section = &Obj->addSection<OwnedDataSection>(
+            ".sec" + std::to_string(SecNo++), RecAddr,
+            ELF::SHF_ALLOC | ELF::SHF_WRITE, SecNo);
----------------
@evgeny777  https://pvs-studio.com/en/blog/posts/cpp/0771/ is warning that the SecNo++ isn't guaranteed to be evaluated in the correct order - maybe perform the increment afterward?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62583/new/

https://reviews.llvm.org/D62583