[PATCH] D104709: [ARM] Revert WLSTP to DLSTP if the target block is out of range

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 23:52:45 PDT 2021


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBlockPlacement.cpp:104
+
+  // Clear the kill flags, as the cmp/bcc will no longer kill any operands.
+  WLS->getOperand(1).setIsKill(false);
----------------
samtebbs wrote:
> Will you need to mark them as killed in the new DLS or is that done automatically?
Yeah it should done automatically if it's needed. The kill flags only need to be conservative, not precise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104709/new/

https://reviews.llvm.org/D104709



More information about the llvm-commits mailing list