[PATCH] D105916: [AsmPrinter][CallGraphSection] Emit call graph section

Necip Fazil Yildiran via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 18:42:41 PDT 2021


necipfazil added a comment.

In D105916#2915350 <https://reviews.llvm.org/D105916#2915350>, @MaskRay wrote:

>> Tomorrow is the last day of my internship. I would like to address any issues before then.
>
> You may continue working on this or ask mentors for help:)
> I added some reviewers to your previous patches and made some comments by myself.
> (But the important thing is that the duration of internship cannot be used to skip review process, especially for such a patch which needs to touch so many components in llvm-project.)

Contrary to the assumption, I would like to contribute as much as I can in the remaining time. Whether the review process is completed or not by then is irrelevant.

> My feelings in https://reviews.llvm.org/D105907#2886280 still stand.
> Perhaps naming the feature "indirect ..." is more suitable. People can likely get confused by the lack of direct call edges.

Thanks for your continued help. I will address the outstanding issues shortly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105916/new/

https://reviews.llvm.org/D105916



More information about the llvm-commits mailing list