[PATCH] D107038: [Bitcode][Asm] Parse metadata value from operand bundles

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 17:01:54 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/test/Bitcode/2021-07-22-Parse-Metadata-Operand-Bundles.ll:1
+; This test ensures that we parse metadata operand bundle values.
+; RUN: llvm-as < %s
----------------
The practice of using 2021-07-22- for tests was probably dropped 10 years ago.
New tests shouldn't follow such patterns.


================
Comment at: llvm/test/Bitcode/2021-07-22-Parse-Metadata-Operand-Bundles.ll:2
+; This test ensures that we parse metadata operand bundle values.
+; RUN: llvm-as < %s
+
----------------
This just checks that it assembles but no actual verification is performed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107038/new/

https://reviews.llvm.org/D107038



More information about the llvm-commits mailing list