[PATCH] D105915: [CallSiteInfo][CallGraphSection] Extend CallSiteInfo for indirect call type ids

[Necip Fazil Yildiran via Phabricator via llvm-commits]

necipfazil marked 5 inline comments as done.
necipfazil added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineFunction.h:425
+
+    CallSiteInfo() : TypeId(nullptr) {}
+
----------------
morehouse wrote:
> This constructor is implicit from the above `TypeId = nullptr`.  We can just remove this.
I kept this since the default constructor is used elsewhere, which is implicity deleted because of the below constructor `CallSiteInfo(const CallBase)`.

Besides, I removed the unnecessary initializers for `TypeId`.


================
Comment at: llvm/lib/CodeGen/MIRPrinter.cpp:522
     // Construct call arguments and theirs forwarding register info.
-    for (auto ArgReg : CSInfo.second) {
+    for (auto ArgReg : CSInfo.second.ArgRegPairs) {
       yaml::CallSiteInfo::ArgRegPair YmlArgReg;
----------------
vitalybuka wrote:
> You can avoid many of them with begin() end() implementation
I am not sure if I understand this. Could you please elaborate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105915/new/

https://reviews.llvm.org/D105915