[PATCH] D107108: [MIPS][CallSiteInfo][NFC] Fill CallSiteInfo only when needed

Necip Fazil Yildiran via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 14:41:10 PDT 2021


necipfazil created this revision.
Herald added subscribers: atanasyan, jrtc27, hiraditya, arichardson, sdardis.
necipfazil requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Argument-register pairs in CallSiteInfo is only needed when EmitCallSiteInfo
is on. Currently, the pairs are always pushed to the vector but only used
when EmitCallSiteInfo is on.

Don't fill the CallSiteInfo vector unless used.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107108

Files:
  llvm/lib/Target/Mips/MipsISelLowering.cpp


Index: llvm/lib/Target/Mips/MipsISelLowering.cpp
===================================================================
--- llvm/lib/Target/Mips/MipsISelLowering.cpp
+++ llvm/lib/Target/Mips/MipsISelLowering.cpp
@@ -3349,7 +3349,7 @@
 
       // Collect CSInfo about which register passes which parameter.
       const TargetOptions &Options = DAG.getTarget().Options;
-      if (Options.SupportsDebugEntryValues)
+      if (Options.EmitCallSiteInfo && Options.SupportsDebugEntryValues)
         CSInfo.emplace_back(VA.getLocReg(), i);
 
       continue;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107108.362887.patch
Type: text/x-patch
Size: 552 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210729/a2c4f32c/attachment.bin>


More information about the llvm-commits mailing list