[PATCH] D107061: [SPEC2017] Copy reference files to run dir, use for compares.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: External/SPEC/CINT2017rate/557.xz_r/CMakeLists.txt:25
 
+set(RUN_INPUT_all_DIR "${CMAKE_CURRENT_BINARY_DIR}/data/all/input")
+
----------------
Meinersbur wrote:
> Why does this need a custom definition of `RUN_INPUT_all_DIR` ?
Thanks, this was left over from an earlier iteration, I removed it.


================
Comment at: External/SPEC/CINT2017rate/557.xz_r/CMakeLists.txt:103
 
+set(RUN_INPUT_train_DIR "${CMAKE_CURRENT_BINARY_DIR}/data/input")
 speccpu2017_run_test(
----------------
Meinersbur wrote:
> Why does this need a custom `RUN_INPUT_train_DIR`?
Thanks, this was left over from an earlier iteration, I removed it.


================
Comment at: External/SPEC/SpecCPU2017.cmake:223
   cmake_parse_arguments(_arg
     "" "RUN_TYPE;SUITE_TYPE;WORKDIR;STDOUT;STDERR" "" ${ARGN})
 
----------------
Meinersbur wrote:
> Did you consider removing the `WORKDIR` argument entirely? Seems that we never want to use a directory other than in the build dir. Are that other uses used of `WORKDIR` left?
That's a great point! It's not needed by any benchmark. I removed it.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107061/new/

https://reviews.llvm.org/D107061