[PATCH] D107097: [llvm-profgen] An option to ignore parsing MMap events

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 13:13:15 PDT 2021


wlei added a comment.

In D107097#2914447 <https://reviews.llvm.org/D107097#2914447>, @lxfind wrote:

> Having both "--show-mmap-events --ignore-mmap-events" seems a bit counter-intuitive.
> If we already preprocessed the mmap events, could we also assume that we have the right pids and hence don't need --show-mmap-events?

Thanks for the feedback, the `--show-mmap-events` here is different from the linux `perf script`, here is to show the mmap events paring results, only for debugging use I think.

And in this test, see the directive: `; CHECK-IGNORE-NOT: Mmap: Binary /home/a.out loaded at 0x400000` which means `--show-mmap-events ` won't work with `--ignore-mmap-events`.

I can add a warning here if it's confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107097/new/

https://reviews.llvm.org/D107097



More information about the llvm-commits mailing list