[PATCH] D107014: [llvm-profgen] Refactor PerfReader to allow different types of perf scripts

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

Thanks for working on this. We can continue from here to support more types of trace files, for non-cs profiles and more .



================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:55
 
+void ProfiledBinary::showBinaryDisasmOnly(
+    cl::list<std::string> &BinaryFilenames) {
----------------
The function does more than disassembling, maybe name it `LoadBinary` and move it out of the `ProfiledBinary` class?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107014/new/

https://reviews.llvm.org/D107014