[PATCH] D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D105207#2913088 <https://reviews.llvm.org/D105207#2913088>, @jmorse wrote:

> (Chris is out today,)
>
> In D105207#2912487 <https://reviews.llvm.org/D105207#2912487>, @mstorsjo wrote:
>
>> Unreduced repro: https://martin.st/temp/d3dx-preproc.c
>>
>> clang -target aarch64-linux-gnu -w -c -g -O2 d3dx-preproc.c
>
> Thanks for the repo -- I've just pushed up rG2537120c8 <https://reviews.llvm.org/rG2537120c870c04893636f171f553024f378c2de8> as an obvious fix, none affine expressions are being fed to a function that doesn't expect them, and it's safe to return and not salvage variable locations in that case. I think it's just a case of an assertion being insufficiently filtered for.
>
> If there's more / continued turbulence then we'll revert though, and we'll add test coverage for non-affine SCEVs being salvaged either way.

Thanks for the quick fix on this matter! For now I think it seems like this issue is fixed wrt the code I test build regularly, but I'll know more exhaustively tomorrow.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105207/new/

https://reviews.llvm.org/D105207