[PATCH] D105676: [AArch64][GlobalISel] Relax oneuse restriction for PTR_ADD chain combining to check addressing legality.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/combine-ptradd-reassociation.mir:26-27
     %0:_(p0) = COPY $x0
     %2:_(s64) = G_CONSTANT i64 4777
     %4:_(s64) = G_CONSTANT i64 6
     %9:_(s32) = G_CONSTANT i32 0
----------------
I think this test is actually wrong, not sure how it slipped through. To properly test the reassociation behavior we should use a legal offset. Can you replace the 4777 with 1600 and the 6 with 3?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/combine-ptradd-reassociation.mir:176-177
     %0:_(p0) = COPY $x0
     %2:_(s64) = G_CONSTANT i64 4777
     %4:_(s64) = G_CONSTANT i64 6
     %9:_(s32) = G_CONSTANT i32 0
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105676/new/

https://reviews.llvm.org/D105676