[PATCH] D107012: [DWARF] Refactor test to remove relocations for DWO

Thu Jul 29 10:12:04 PDT 2021

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds good, thanks!

================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-header.s:430
         .byte   1               # DW_LNCT_path
-        .byte   0x0e            # DW_FORM_strp (-> .debug_str.dwo)
+        .byte   0x25            # DW_FORM_strx1 (-> .debug_str.dwo)
         # Directory table entries
----------------
ayermolo wrote:
> dblaikie wrote:
> > That doesn't look right, does it? 0x25 would be too large an index for the .debug_str_offsets.dwo section - there are only 5 things in there, so the valid indexes should be [0, 4], I think?
> This is encoding for DW_FORM_strx1.
> 0xe --> HANDLE_DW_FORM(0x0e, strp, 2, DWARF)
> 0x25 --> HANDLE_DW_FORM(0x25, strx1, 5, DWARF)
> 
> At least this is my understanding of what is happening here looking at comments and value of original .byte
Oh, sorry - this is the abbreviation rather than the values, right right. Sorry about that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107012/new/

https://reviews.llvm.org/D107012