[PATCH] D104709: [ARM] Revert WLSTP to DLSTP if the target block is out of range

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 09:08:49 PDT 2021


samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBlockPlacement.cpp:104
+
+  // Clear the kill flags, as the cmp/bcc will no longer kill any operands.
+  WLS->getOperand(1).setIsKill(false);
----------------
Will you need to mark them as killed in the new DLS or is that done automatically?


================
Comment at: llvm/lib/Target/ARM/ARMBlockPlacement.cpp:120
+
+  // Create a new DPS to replace the WLS
+  MachineInstrBuilder MIB =
----------------
DPS -> DLS ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104709/new/

https://reviews.llvm.org/D104709



More information about the llvm-commits mailing list