[PATCH] D107012: [DWARF] Refactor test to remove relocations for DWO

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-header.s:24
         .section .debug_str.dwo,"MSe", at progbits,1
-dwo_TU_5:
+.dwo_TU_5:
         .asciz "V5_split_type_unit"
----------------
Don't think there's a need to add the '.' at the start here in these labels? (leave it out like other labels above, etc?)


================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-header.s:430
         .byte   1               # DW_LNCT_path
-        .byte   0x0e            # DW_FORM_strp (-> .debug_str.dwo)
+        .byte   0x25            # DW_FORM_strx1 (-> .debug_str.dwo)
         # Directory table entries
----------------
That doesn't look right, does it? 0x25 would be too large an index for the .debug_str_offsets.dwo section - there are only 5 things in there, so the valid indexes should be [0, 4], I think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107012/new/

https://reviews.llvm.org/D107012