[PATCH] D106362: [FPEnv][InstSimplify] Enable more folds for constrained fadd

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 06:53:41 PDT 2021


kpn added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4922
 
   // With nnan: -X + X --> 0.0 (and commuted variant)
   // We don't have to explicitly exclude infinities (ninf): INF + -INF == NaN.
----------------
sepavloff wrote:
> What about making such transformation in non-default mode?
It requires adding support to the IR matchers like m_FSub(), and those are used elsewhere. Which implies testing in places in addition to here. So I'm saving that for a subsequent patch.

Small steps.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106362/new/

https://reviews.llvm.org/D106362



More information about the llvm-commits mailing list