[PATCH] D107058: [SLP]Fix a crash in gathered loads analysis.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7451
 
     unsigned MinVF = std::max(2U, R.getMinVecRegSize() / EltSize);
     unsigned MaxVF = std::min(R.getMaximumVF(EltSize, Instruction::Store),
----------------
spatel wrote:
> Similar logic...
Will try.


================
Comment at: llvm/test/Transforms/SLPVectorizer/AArch64/loads-gather-crash.ll:4
+
+define void @foo() local_unnamed_addr {
+; CHECK-LABEL: @foo(
----------------
sdesmalen wrote:
> Could you name the test to something more descriptive, e.g. `gather-load-min-required-vf-2.ll` (feel free to come up with something better) and also add a comment explaining why the code should not be slp-vectorized?
Ok, no problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107058/new/

https://reviews.llvm.org/D107058