[PATCH] D107058: [SLP]Fix a crash in gathered loads analysis.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 05:41:44 PDT 2021


spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7451
 
     unsigned MinVF = std::max(2U, R.getMinVecRegSize() / EltSize);
     unsigned MaxVF = std::min(R.getMaximumVF(EltSize, Instruction::Store),
----------------
Similar logic...


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7562
   unsigned Sz = R.getVectorElementSize(I0);
   unsigned MinVF = std::max(2U, R.getMinVecRegSize() / Sz);
   unsigned MaxVF = std::max<unsigned>(PowerOf2Floor(VL.size()), MinVF);
----------------
And again...can we consolidate these into a helper call to avoid the problem consistently?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107058/new/

https://reviews.llvm.org/D107058



More information about the llvm-commits mailing list