[PATCH] D107060: [SPEC2017] Add timeit dependencies to validator and bench binaries.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 05:33:18 PDT 2021


fhahn created this revision.
fhahn added reviewers: naromero77, Meinersbur, cmatthews, paquette.
Herald added a subscriber: mgorny.
fhahn requested review of this revision.

Both the benchmark and validator binaries require timeit on the host
system to measure the build times. They also need timeit-target, to
measure execution time on the system where the benchmarks execute.

This patch explicitly adds those dependencies, so they are guaranteed to
be built, even if individual benchmark binaries are built.


Repository:
  rT test-suite

https://reviews.llvm.org/D107060

Files:
  External/SPEC/SpecCPU2017.cmake


Index: External/SPEC/SpecCPU2017.cmake
===================================================================
--- External/SPEC/SpecCPU2017.cmake
+++ External/SPEC/SpecCPU2017.cmake
@@ -274,6 +274,7 @@
     add_executable(${VALIDATOR} ${_validator_sources})
     target_link_libraries(${VALIDATOR} m)
     set_target_properties(${VALIDATOR} PROPERTIES COMPILE_FLAGS "-DSPEC")
+    add_dependencies(${VALIDATOR} build-timeit)
     add_dependencies(${VALIDATOR} build-timeit-target)
   endif ()
 
@@ -345,6 +346,8 @@
   endif ()
 
   llvm_test_executable(${PROG} ${_sources})
+  add_dependencies(${PROG} build-timeit)
+  add_dependencies(${PROG} build-timeit-target)
 
   if (TARGET ${VALIDATOR})
     add_dependencies(${PROG} ${VALIDATOR})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107060.362728.patch
Type: text/x-patch
Size: 736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210729/7c31bc7c/attachment.bin>


More information about the llvm-commits mailing list