[PATCH] D106335: [flang][OpenMP] Add semantic check for teams nesting

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 02:46:33 PDT 2021


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.

LGTM.

@clementval do you have further comments?



================
Comment at: flang/lib/Semantics/check-omp-structure.h:254
+
+  int directiveNest_[3] = {0};
+  enum directiveNestType { SIMDNest, TargetBlockOnlyTeams, LastType };
----------------
Nit: Sorry, I meant can you move this below the enum and use LastType (with SIMDNest =1 ) or LastType +1 as the size of the directiveNest_array?

```
enum directiveNestType { SIMDNest, TargetBlockOnlyTeams, LastType };
int directiveNest_[LastType+1] = {0};
```



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106335/new/

https://reviews.llvm.org/D106335



More information about the llvm-commits mailing list