[PATCH] D104848: [cmake] Handled utils/unittests before projects

[Jakub Chlanda via Phabricator via llvm-commits]

jchlanda added a comment.

SYCL already predicates building unittests on the value of `LLVM_INCLUDE_TESTS` (https://github.com/intel/llvm/blob/sycl/sycl/CMakeLists.txt#L212). The problem is that at the point of time when `check-sycl` is built `gtests` are not known to CMake (even though SYCL code did check for the existence of the source), so it is impossible to add them to the list of dependencies. Yes they will be built (if the `LLVM_INCLUDE_TESTS` is set on), but the dependency will not be set up correctly and depending on the order in which the targets are built `check-sycl` might fail to link. It boils down to inter-target dependencies in CMake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104848/new/

https://reviews.llvm.org/D104848