[PATCH] D106538: [flang][OpenMP] Add semantic check for cancellation nesting

[Peixin Qiao via Phabricator via llvm-commits]

peixin added a comment.

@kiranchandramohan Thanks for the explanation and review.

Add the test case you provided that I did not catch in last patch and other three scenarios that should also be not permitted by the standard. The implementation of `cancel taskgroup` is fixed to cover these test scenarios.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:934
+  } else {
+    context_.Say(source, "orphaned %s directives are prohibited"_err_en_US,
+        ContextDirectiveAsFortran());
----------------
kiranchandramohan wrote:
> Nit: Can you provide a better error message here? Like "%s directive is not closely nested inside %s"
Fixed the error message. Could you please check if it is ok now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106538/new/

https://reviews.llvm.org/D106538