[PATCH] D106942: Consider section flags when adding section

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Could you please add a test case to the existing llvm-objcopy tests (llvm/test/tools/llvm-objcopy) that shows this fix works.



================
Comment at: llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp:232
 
   for (const auto &Flag : Config.AddSection) {
     StringRef SecName, FileName;
----------------
Rather than modify `flagsToCharacteristics`, could you just move this loop above the SetSectionFlags block above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106942/new/

https://reviews.llvm.org/D106942